chore(context-menu): context menu feature flag #7074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
no release notes
kraenhansen
force-pushed
the
kh/context-menu-feature-flag
branch
from
d834fa9 to
ce04745
Compare
kraenhansen
force-pushed
the
kh/context-menu-feature-flag
branch
from
ce04745 to
4f5a9f5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new enableContextMenus feature flag and updates various components to allow toggling context menu support at runtime.
- Adds
enableContextMenusto the preferences model and feature-flag metadata - Reads the new flag in the Home component and passes a
disableContextMenusprop into the components provider - Updates the ContextMenuProvider and CompassComponentsProvider to respect the
disabledsetting
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass/src/app/components/home.tsx | Import and read enableContextMenus preference, pass disableContextMenus into provider |
| packages/compass-preferences-model/src/feature-flags.ts | Add enableContextMenus to the FeatureFlags type and metadata |
| packages/compass-context-menu/src/context-menu-provider.tsx | Add disabled prop to gate event listeners when context menus are off |
| packages/compass-components/src/components/context-menu.tsx | Propagate disabled through the wrapper consumer |
| packages/compass-components/src/components/compass-components-provider.tsx | Add disableContextMenus prop and forward to ContextMenuProvider |
Comments suppressed due to low confidence (4)
packages/compass-context-menu/src/context-menu-provider.tsx:21
- There are no tests verifying that context menus are correctly disabled when
disabledis true; consider adding unit tests for this behavior.
disabled = false,
packages/compass-preferences-model/src/feature-flags.ts:29
- New feature flag
enableContextMenusis added but there’s no documentation or examples in the project README or API docs; please update documentation to reflect this flag.
enableContextMenus: boolean;
packages/compass-components/src/components/compass-components-provider.tsx:38
- [nitpick] The prop
disableContextMenusintroduces a double negative; consider usingenableContextMenus(and passing through the positive flag) to improve readability.
/**
packages/compass/src/app/components/home.tsx:36
- The import path for
usePreferenceseems incorrect; it should be imported from '@mongodb-js/compass-preferences-model/provider' to match other scoped packages.
import { usePreference } from 'compass-preferences-model/provider';
Anemy
approved these changes
Jul 1, 2025
Contributor
Author
|
Merging with an unrelated failure on the smoke tests on RPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes